Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing rename remnants #194

Merged
merged 7 commits into from
Jun 15, 2016
Merged

Conversation

bsipocz
Copy link
Contributor

@bsipocz bsipocz commented Apr 13, 2016

There were a few remaining mentions of pyasdf, this PR changes those.

Also the asdf-standard submodule wasn't updated to the one with the rename changes (as there wasn't a release, I used the hash of the current master and not a release tag).

And as a "bonus", this updates to the latest astropy-helpers, too.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.761% when pulling 3faac14 on bsipocz:fixing_rename_remnants into 18ec694 on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.033% when pulling 98b072c on bsipocz:fixing_rename_remnants into 18ec694 on spacetelescope:master.

@bsipocz bsipocz force-pushed the fixing_rename_remnants branch 2 times, most recently from cf9b78c to 7161035 Compare April 13, 2016 17:44
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.033% when pulling 7161035 on bsipocz:fixing_rename_remnants into 18ec694 on spacetelescope:master.

@nden
Copy link
Contributor

nden commented Apr 13, 2016

Thanks @bsipocz The failure is a known problem, see #192 . Unless someone objects I will merge soon.

@bsipocz
Copy link
Contributor Author

bsipocz commented Apr 13, 2016

@nden - I've played around a bit trying to solve it within the asdf sphinx extension, but it's far from being trivial.

@bsipocz
Copy link
Contributor Author

bsipocz commented Apr 13, 2016

The sphinx build for this latest commit will fail now, but astropy/ci-helpers#78 will fix it (so it'll need a restart once that one is merged).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.033% when pulling 72867ac on bsipocz:fixing_rename_remnants into 18ec694 on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.856% when pulling 6479d0c on bsipocz:fixing_rename_remnants into f93bb0b on spacetelescope:master.

@bsipocz
Copy link
Contributor Author

bsipocz commented Jun 15, 2016

I've rebased this, and now seems to get the green from travis.

@nden
Copy link
Contributor

nden commented Jun 15, 2016

Thanks @bsipocz .

@nden nden merged commit b8a7ad6 into asdf-format:master Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants